Repository navigation
fix(mkconcore): copy MATLAB literal helper files into generated studies - #672
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
|
🎉 Welcome aboard, @yadavchiragg! Thank you for your first pull request in concore. Please ensure that you are contributing to the dev branch. Your contribution means a lot to us. We'll review it shortly. Please ensure you have reviewed our: If you have any questions, feel free to ask. Happy coding! |
yadavchiragg
force-pushed
the
fix/matlab-literal-helpers
branch
from
November 13, 2026 03:08
c779ee3 to
5668c95
Compare
yadavchiragg
force-pushed
the
fix/matlab-literal-helpers
branch
from
November 13, 2026 03:10
5668c95 to
aac8695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648
Problem: concore_read.m, concore_write.m, concore_initval.m and concore_default_maxtime.m call concore_literal_eval and concore_literal_serialize, but mkconcore.py never copied those two files into the generated src/ folder. A MATLAB/Octave node would fail on its first read or write.
Change: copy both helpers alongside the other concore_.m runtime files. The generated build scripts already copy concore_.m with a wildcard, so no change was needed there. mkconcore.py has mixed line endings, so the edit keeps the existing ones.
Testing: new tests/test_matlab_runtime_files.py generates demo/sampleM.graphml for posix, windows and docker. It checks both helpers are in src/, that every concore_* function called by a copied runtime file is itself copied, and that the build script still uses the concore_*.m wildcard. 6 of the 8 tests fail on current dev and pass with this change. ruff format --check and ruff check are clean.
Not run under real MATLAB or Octave, only checked at the generated-files level.